Spotter-Cluster/Spotter-VM
2
0
Fork 0
Code Issues 78 Pull Requests Actions Packages Projects Releases Wiki Activity

SE - Doprava - import Heliport #7

New Issue
Closed
opened 2017-09-18 15:49:07 +02:00 by Podhorecky · 10 comments
Podhorecky commented 2017-09-18 15:49:07 +02:00 (Migrated from git.spotter.cz)
Copy Link

Steps to reproduce

  1. https://dasm.dasm.cz:8443/eden/transport/heliport/import
  2. vyberu XLS soubor kde na 1. záložce je požadovaný import (importuje se pouze 1. záložka)
  3. čekám že uvidim import

Expected behaviour

upload XLS template

Observed behaviour

https://dasm.dasm.cz:8443/eden/admin/ticket/eden/94.230.157.167.2017-09-18.15-43-33.bc20d7e5-0eaa-4266-83ef-c5761dd8ca9b

Additional data (ticket URL, log, timestamp, stack trace etc.)

tohle bude asi na více místech s uploadem. 7_Letiste_Heli_Nadrazi_Prechody.xlsx

například import hraničních přechodů proběhl OK - viz DB a mapa.

předpoklad je, že kdyby v XLS template byly nějaké chybné sloupce, tak se nebudou importovat a nebo dostanu před importem upozornění že data jsou špatně

### Steps to reproduce 1. https://dasm.dasm.cz:8443/eden/transport/heliport/import 2. vyberu XLS soubor kde na 1. záložce je požadovaný import (importuje se pouze 1. záložka) 3. čekám že uvidim import ### Expected behaviour upload XLS template ### Observed behaviour https://dasm.dasm.cz:8443/eden/admin/ticket/eden/94.230.157.167.2017-09-18.15-43-33.bc20d7e5-0eaa-4266-83ef-c5761dd8ca9b ### Additional data (ticket URL, log, timestamp, stack trace etc.) tohle bude asi na více místech s uploadem. [7_Letiste_Heli_Nadrazi_Prechody.xlsx](/uploads/1c5e9c7545630094855ab84c6207f06e/7_Letiste_Heli_Nadrazi_Prechody.xlsx) například import hraničních přechodů proběhl OK - viz DB a mapa. předpoklad je, že kdyby v XLS template byly nějaké chybné sloupce, tak se nebudou importovat a nebo dostanu před importem upozornění že data jsou špatně
Podhorecky commented 2017-09-18 15:49:43 +02:00 (Migrated from git.spotter.cz)
Copy Link

changed title from S{-ahana - modul-} Doprava - import Heliport to S{+E -+} Doprava - import Heliport

changed title from **S{-ahana - modul-} Doprava - import Heliport** to **S{+E -+} Doprava - import Heliport**
Disassembler commented 2017-09-18 20:16:10 +02:00 (Migrated from git.spotter.cz)
Copy Link

Chyba není problém importu, ale samotného modulu transport. Ruční vytvoření heliportu nebo letiště selže také, protože SE se z letiště nebo heliportu pokouší vytvořit pobočku (site) a jako kód vložit 12 počátečních znaků názvu. Definice databázové tabulky ale povoluje pouze 10 znaků. Prozkoumám, kde ke generování kódu pobočky dochází.

2017-09-18 20:05:27.121 CEST [18904] sahana@sahana LOG:  statement: INSERT INTO transport_heliport(organisation_id,modified_by,name,mci,deleted,site_id,obsolete,comments,owned_by_user,created_on,approved_by,created_by,modified_on,location_id,uuid) VALUES (9,1,'Heliport Bynovec',2,'F',NULL,'F','',1,'2017-09-18 18:05:27',1,1,'2017-09-18 18:05:27',337,'urn:uuid:7765f713-f130-4800-af1c-00126e5aaebd') RETURNING id;
2017-09-18 20:05:27.122 CEST [18904] sahana@sahana LOG:  statement: SELECT  transport_heliport.organisation_id, transport_heliport.code, transport_heliport.uuid, transport_heliport.deleted, transport_heliport.realm_entity, transport_heliport.site_id, transport_heliport.obsolete, transport_heliport.comments, transport_heliport.owned_by_user, transport_heliport.owned_by_group, transport_heliport.location_id, transport_heliport.name FROM transport_heliport WHERE (transport_heliport.id = 6) ORDER BY transport_heliport.id LIMIT 1 OFFSET 0;
2017-09-18 20:05:27.123 CEST [18904] sahana@sahana LOG:  statement: INSERT INTO org_site(organisation_id,code,uuid,deleted,realm_entity,obsolete,comments,owned_by_user,instance_type,owned_by_group,location_id,name) VALUES (9,NULL,'urn:uuid:7765f713-f130-4800-af1c-00126e5aaebd','F',NULL,'F','',1,'transport_heliport',NULL,337,'Heliport Bynovec') RETURNING site_id;
2017-09-18 20:05:27.124 CEST [18904] sahana@sahana LOG:  statement: SELECT  org_site.site_id FROM org_site WHERE (org_site.code = 'HELIPORT BYNO') ORDER BY org_site.site_id LIMIT 1 OFFSET 0;
2017-09-18 20:05:27.124 CEST [18904] sahana@sahana LOG:  statement: UPDATE org_site SET code='HELIPORT BYNO' WHERE (org_site.site_id = 6);
2017-09-18 20:05:27.125 CEST [18904] sahana@sahana ERROR:  value too long for type character varying(10)
2017-09-18 20:05:27.125 CEST [18904] sahana@sahana STATEMENT:  UPDATE org_site SET code='HELIPORT BYNO' WHERE (org_site.site_id = 6);
Chyba není problém importu, ale samotného modulu *transport*. Ruční vytvoření heliportu nebo letiště selže také, protože SE se z letiště nebo heliportu pokouší vytvořit pobočku (*site*) a jako kód vložit 12 počátečních znaků názvu. Definice databázové tabulky ale povoluje pouze 10 znaků. Prozkoumám, kde ke generování kódu pobočky dochází. ```sql 2017-09-18 20:05:27.121 CEST [18904] sahana@sahana LOG: statement: INSERT INTO transport_heliport(organisation_id,modified_by,name,mci,deleted,site_id,obsolete,comments,owned_by_user,created_on,approved_by,created_by,modified_on,location_id,uuid) VALUES (9,1,'Heliport Bynovec',2,'F',NULL,'F','',1,'2017-09-18 18:05:27',1,1,'2017-09-18 18:05:27',337,'urn:uuid:7765f713-f130-4800-af1c-00126e5aaebd') RETURNING id; 2017-09-18 20:05:27.122 CEST [18904] sahana@sahana LOG: statement: SELECT transport_heliport.organisation_id, transport_heliport.code, transport_heliport.uuid, transport_heliport.deleted, transport_heliport.realm_entity, transport_heliport.site_id, transport_heliport.obsolete, transport_heliport.comments, transport_heliport.owned_by_user, transport_heliport.owned_by_group, transport_heliport.location_id, transport_heliport.name FROM transport_heliport WHERE (transport_heliport.id = 6) ORDER BY transport_heliport.id LIMIT 1 OFFSET 0; 2017-09-18 20:05:27.123 CEST [18904] sahana@sahana LOG: statement: INSERT INTO org_site(organisation_id,code,uuid,deleted,realm_entity,obsolete,comments,owned_by_user,instance_type,owned_by_group,location_id,name) VALUES (9,NULL,'urn:uuid:7765f713-f130-4800-af1c-00126e5aaebd','F',NULL,'F','',1,'transport_heliport',NULL,337,'Heliport Bynovec') RETURNING site_id; 2017-09-18 20:05:27.124 CEST [18904] sahana@sahana LOG: statement: SELECT org_site.site_id FROM org_site WHERE (org_site.code = 'HELIPORT BYNO') ORDER BY org_site.site_id LIMIT 1 OFFSET 0; 2017-09-18 20:05:27.124 CEST [18904] sahana@sahana LOG: statement: UPDATE org_site SET code='HELIPORT BYNO' WHERE (org_site.site_id = 6); 2017-09-18 20:05:27.125 CEST [18904] sahana@sahana ERROR: value too long for type character varying(10) 2017-09-18 20:05:27.125 CEST [18904] sahana@sahana STATEMENT: UPDATE org_site SET code='HELIPORT BYNO' WHERE (org_site.site_id = 6); ```
Disassembler commented 2017-09-18 20:16:17 +02:00 (Migrated from git.spotter.cz)
Copy Link

added ~14 label

added ~14 label
Disassembler commented 2017-09-18 20:17:27 +02:00 (Migrated from git.spotter.cz)
Copy Link

mentioned in issue #9

mentioned in issue #9
Disassembler commented 2017-09-19 10:28:07 +02:00 (Migrated from git.spotter.cz)
Copy Link

closed via commit 7c577389c1

closed via commit 7c577389c181a4962a3eec32a52aa2866b414c62
Disassembler commented 2017-09-19 10:30:17 +02:00 (Migrated from git.spotter.cz)
Copy Link

removed ~14 label

removed ~14 label
Disassembler commented 2017-09-19 10:33:29 +02:00 (Migrated from git.spotter.cz)
Copy Link

Tak to nakonec byla chyba u nás. Žádal jste délku kódu site 13, ale pole v databázi je omezeno na 10, takže bez úpravy struktury a asi tak stopadesáti řádků kódu na nejrůznějších místech by to nešlo. Dopsal jsem tu informaci i do dokumentace.

Tak to nakonec byla chyba u nás. Žádal jste délku kódu *site* 13, ale pole v databázi je omezeno na 10, takže bez úpravy struktury a asi tak stopadesáti řádků kódu na nejrůznějších místech by to nešlo. Dopsal jsem tu informaci i [do dokumentace](https://git.spotter.cz:8443/Spotter-Cluster/Spotter-Cluster/wikis/Sahana-configuration-and-modules-usability-report#-settingsorgsite_code_len).
Disassembler commented 2017-09-19 10:36:34 +02:00 (Migrated from git.spotter.cz)
Copy Link

mentioned in issue #16

mentioned in issue #16
Disassembler commented 2017-09-19 10:39:05 +02:00 (Migrated from git.spotter.cz)
Copy Link

mentioned in issue #17

mentioned in issue #17
Podhorecky commented 2018-03-14 22:57:42 +01:00 (Migrated from git.spotter.cz)
Copy Link

changed milestone to %2

changed milestone to %2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app-basic
Related to OS or core applications
app-ckan
Related to CKAN
app-crisiscleanup
Related to Crisis Cleanup
app-cts
Related to CTS
app-decidim
Related to Decidim
app-dhis2
Related to DHIS2
app-frontlinesms
Related to FrontlineSMS
app-gnuhealth
Related to GNU Health
app-kanboard
Related to Kanboard
app-mifosx
Related to Mifos X
app-motech
Related to Motech
app-odoo
Related to Odoo
app-opendatakit
Related to OpenDataKit
app-pandora
Related to Pan.do/ra
app-sahana
Related to Sahana Eden
app-seeddms
Related to SeedDMS
app-sigmah
Related to Sigmah
app-taarifa
Related to Taarifa Waterpoints
app-ushahidi
Related to Ushahidi
critical
High priority issue requiring immediate action
CZ
documentation
Needs clarification in documentation
Doing
enhancement
Feature addition or modification
GMaps
info
Mapbox
needinfo
Additional details required
new-app
Suggestion for new application
OSM
performance
Affects resource utilization
QGIS
regression
Feature which previously worked but has been recently broken
suggestion
Proposition of implementation or issue resolution
To Do
upstream
Dependent on resolution by 3rd party
No Label
app-sahana
critical
Milestone
No items
No Milestone Sahana Eden bugreport
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Spotter-Cluster/Spotter-VM#7
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?